Packages / follow-redirects / Security

ModerateVulnerabilityGHSA-cxjh-pqwp-8mfpCVE-2024-28849Published 14 Mar 2024

follow-redirects' Proxy-Authorization header kept across hosts

Your version

Affected releases · follow-redirects

  • 1.x1.0.0 – 1.15.5Fixed in 1.15.6
  • 0.3.x and older0.0.1 – 0.3.0No fix, no longer updated

On 1.x, the newest line:

npm install follow-redirects@1.15.6
Every release on a timeline
1.x
  1. Affected

    1.0.0 – 1.15.5

    54 releases

  2. Fixed

    1.15.6 – 1.16.3

    10 releases, latest

0.x
  1. Affected

    0.0.1 – 0.3.0

    10 releases

74 stable releases of follow-redirects, oldest to newest, one row per major.

What happens

When using axios, its dependency follow-redirects only clears authorization header during cross-domain redirect, but allows the proxy-authentication header which contains credentials too.

Steps To Reproduce & PoC

Test code:

const axios = require('axios');

axios.get('http://127.0.0.1:10081/', {
 headers: {
 'AuThorization': 'Rear Test',
 'ProXy-AuthoriZation': 'Rear Test',
 'coOkie': 't=1'
 }
})
 .then((response) => {
 console.log(response);
 })

When I meet the cross-domain redirect, the sensitive headers like authorization and cookie are cleared, but proxy-authentication header is kept.

Impact

This vulnerability may lead to credentials leak.

Recommendations

Remove proxy-authentication header during cross-domain redirect

Recommended Patch

follow-redirects/index.js:464

- removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
+ removeMatchingHeaders(/^(?:authorization|proxy-authorization|cookie)$/i, this._options.headers);

A whole project to check? Paste its package.json in the dependency check: every deprecated, outdated or vulnerable dependency, with what to upgrade to. Free, no account.