Packages / vite / Security

ModerateVulnerabilityGHSA-8jhw-289h-jh2gCVE-2024-31207Published 3 Apr 2024

Vite's `server.fs.deny` did not deny requests for patterns with directories.

Affected releases · vite

  • 5.x5.0.0 – 5.2.5Fixed in 5.2.6
  • 4.x4.0.0 – 4.5.2Fixed in 4.5.3
  • 3.x3.0.0 – 3.2.8Fixed in 3.2.10
  • 2.x2.7.0 – 2.9.17Fixed in 2.9.18

On 5.x, the newest line:

npm install vite@5.2.6
8.x

  1. Not affected

    8.0.0 – 8.3.5

    34 releases, latest

5.x

  1. Affected

    5.0.0 – 5.0.12

    13 releases

  2. Fixed

    5.0.13

    1 release

  3. Affected

    5.1.0 – 5.1.6

    7 releases

  4. Fixed

    5.1.7 – 5.1.8

    2 releases

  5. Affected

    5.2.0 – 5.2.5

    6 releases

  6. Fixed

    5.2.6 – 5.4.21

    38 releases

4.x

  1. Affected

    4.0.0 – 4.5.2

    42 releases

  2. Fixed

    4.5.3 – 4.5.14

    11 releases

3.x

  1. Affected

    3.0.0 – 3.2.8

    28 releases

  2. Fixed

    3.2.10 – 3.2.11

    2 releases

2.x

  1. Not affected

    2.0.0 – 2.6.14

    57 releases

  2. Affected

    2.7.0 – 2.9.17

    39 releases

  3. Fixed

    2.9.18

    1 release

440 stable releases of vite, oldest to newest, one row per major.

Is your project affected?

Paste your package.json, or type the range you declare for vite. It is read in your browser and sent nowhere.

What happens

Summary

Vite dev server option server.fs.deny did not deny requests for patterns with directories. An example of such a pattern is /foo/**/*.

Impact

Only apps setting a custom server.fs.deny that includes a pattern with directories, and explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.

Patches

Fixed in vite@5.2.6, vite@5.1.7, vite@5.0.13, vite@4.5.3, vite@3.2.10, vite@2.9.18

Details

server.fs.deny uses picomatch with the config of { matchBase: true }. matchBase only matches the basename of the file, not the path due to a bug (#89). The vite config docs read like you should be able to set fs.deny to glob with picomatch. Vite also does not set { dot: true } and that causes dotfiles not to be denied unless they are explicitly defined.

Reproduction

Set fs.deny to ['**/.git/**'] and then curl for /.git/config.

  • with matchBase: true, you can get any file under .git/ (config, HEAD, etc).

  • with matchBase: false, you cannot get any file under .git/ (config, HEAD, etc).